threads: enable PTHREAD_{MUTEX,RWLOCK,COND}_INITIALIZER
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
I think the idea made sense to me but initially it was a bit unclear why the comparison test for expected/wasm32-wasi/predefined-macros.txt was not failing: if we unconditionally #define these PTHREAD_*_INITIALIZERs then I was expecting a diff error. But no: pthread.h is already omitted entirely when THREAD_MODEL=single in the top-level Makefile so these will only be defined when THREAD_MODEL=posix. And they will always be defined then, which I think is what we want. LGTM!
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
abrown
added a commit
to abrown/wasi-sdk
that referenced
this pull request
Mar 20, 2023
This change brings in several helpful PRs (e.g., WebAssembly/wasi-libc#397, WebAssembly/wasi-libc#399, WebAssembly/wasi-libc#401) in anticipation of creating a release based on LLVM 16.
abrown
added a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Mar 22, 2023
This change brings in several helpful PRs (e.g., WebAssembly/wasi-libc#397, WebAssembly/wasi-libc#399, WebAssembly/wasi-libc#401) in anticipation of creating a release based on LLVM 16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
defined(_REENTRANT)was added here and it was just to mark these as modifiied. (@sunfishcode would know for sure.)With this change I can build libcxxabi, libcxx, and boost with threads enabled, and link a few binaries (that do not spawn threads, but use mutexes).